Replace websocket with tungstenite for turbo-trace-server #8099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
turbo-orchestrator
bot
added
needs: triage
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
approved these changes
May 7, 2024
arlyon
approved these changes
May 7, 2024
sokra
deleted the
05-07-Replace_websocket_with_tungstenite_for_turbo-trace-server
branch
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 8, 2024
* vercel/turbo#8073 <!-- OJ Kwon - feat(webpack-loaders): support dummy span interface --> * vercel/turbo#8083 <!-- OJ Kwon - fix(webpack): print resource, project path when relative calc fails --> * vercel/turbo#8094 <!-- Tim Neutkens - Implement bindings for Turbopack trace server --> * vercel/turbo#8061 <!-- Tobias Koppers - reduce memory usage in analyser --> * vercel/turbo#8077 <!-- Alexander Lyon - Remove async-trait from a few crates --> * vercel/turbo#8102 <!-- Tobias Koppers - fix memory counting without custom allocator --> * vercel/turbo#8096 <!-- Benjamin Woodruff - turbo-tasks: Expand `<T as TaskOutput>::Return` values in macros --> * vercel/turbo#8105 <!-- Benjamin Woodruff - turbopack-node: Use path.join for postcss loader --> * vercel/turbo#8099 <!-- Tim Neutkens - Replace websocket with tungstenite for turbo-trace-server --> * vercel/turbo#8060 <!-- Donny/강동윤 - feat: Add lint for `grid-template-areas` --> * vercel/turbo#8110 <!-- Tobias Koppers - fix lockfile -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
websocketcan't be compiled to some system targets for Windows and Linux. Based on the readme of the project they recommend usingtungsteniteinstead, this PR implementstungstenitefor turbo-trace-server.While investigating some borrowing issue with @arlyon we found that one of the threads spawned to send messages every 500ms isn't really being used, so I've removed that in favor of the sending on
ackthat is already used.Testing Instructions