feat(filter): error on invalid filters #8142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
Base automatically changed from
chrisolszewski/turbo-3125-stop-inference-of-package-names-in-scope
to
turborepo_2
May 15, 2024 00:20
🟢 CI successful 🟢Thanks |
chris-olszewski
commented
May 15, 2024
chris-olszewski
force-pushed
the
chrisolszewski/turbo-2711-make-filter-strict
branch
from
ce72c59
to
1b233da
Compare
chris-olszewski
force-pushed
the
chrisolszewski/turbo-2711-make-filter-strict
branch
from
1b233da
to
39e1c18
Compare
mehulkar
approved these changes
May 15, 2024
| @@ -2,13 +2,17 @@ Setup | |||
| $ . ${TESTDIR}/../../../helpers/setup_integration_test.sh | |||
|
|
|||
| # Save JSON to tmp file so we don't need to keep re-running the build | |||
| $ ${TURBO} run build --dry=json --filter=main > tmpjson.log | |||
| $ ${TURBO} run build --dry=json --filter='[main]' > tmpjson.log | |||
There was a problem hiding this comment.
I think I wrote these tests? but I am not sure if even this is valid usage of --filter
There was a problem hiding this comment.
I believe you wanted to write a filter for changes since main, but without the brackets it was just a filter for the non-existent main package.
I don't think we should since we decided to only error on clearly wrong filters and not all filters that don't run tasks. For a similar reason we don't error if the user runs |
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2024
### Description This PR changes `--filter` so it now will error on certain malformed filters: - Name filters with no globs that don't match any packages e.g. `--filter=fo` instead of `--filter=foo` - Directory filters that reference a directory that doesn't exist: e.g. `--filter='./pakcages/*'` Each commit of the PR can be reviewed on it's own. ### Testing Instructions Updated existing unit tests. Added additional ones along with an integration test.
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description This PR changes `--filter` so it now will error on certain malformed filters: - Name filters with no globs that don't match any packages e.g. `--filter=fo` instead of `--filter=foo` - Directory filters that reference a directory that doesn't exist: e.g. `--filter='./pakcages/*'` Each commit of the PR can be reviewed on it's own. ### Testing Instructions Updated existing unit tests. Added additional ones along with an integration test.
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description This PR changes `--filter` so it now will error on certain malformed filters: - Name filters with no globs that don't match any packages e.g. `--filter=fo` instead of `--filter=foo` - Directory filters that reference a directory that doesn't exist: e.g. `--filter='./pakcages/*'` Each commit of the PR can be reviewed on it's own. ### Testing Instructions Updated existing unit tests. Added additional ones along with an integration test.
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description This PR changes `--filter` so it now will error on certain malformed filters: - Name filters with no globs that don't match any packages e.g. `--filter=fo` instead of `--filter=foo` - Directory filters that reference a directory that doesn't exist: e.g. `--filter='./pakcages/*'` Each commit of the PR can be reviewed on it's own. ### Testing Instructions Updated existing unit tests. Added additional ones along with an integration test.
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description This PR changes `--filter` so it now will error on certain malformed filters: - Name filters with no globs that don't match any packages e.g. `--filter=fo` instead of `--filter=foo` - Directory filters that reference a directory that doesn't exist: e.g. `--filter='./pakcages/*'` Each commit of the PR can be reviewed on it's own. ### Testing Instructions Updated existing unit tests. Added additional ones along with an integration test.
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description This PR changes `--filter` so it now will error on certain malformed filters: - Name filters with no globs that don't match any packages e.g. `--filter=fo` instead of `--filter=foo` - Directory filters that reference a directory that doesn't exist: e.g. `--filter='./pakcages/*'` Each commit of the PR can be reviewed on it's own. ### Testing Instructions Updated existing unit tests. Added additional ones along with an integration test.
|
@chris-olszewski turbo run build --filter='core[main...HEAD]'it works with Turbo v1, but it will throw errors with Turbo v2. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
--filterso it now will error on certain malformed filters:--filter=foinstead of--filter=foo--filter='./pakcages/*'Each commit of the PR can be reviewed on it's own.
Testing Instructions
Updated existing unit tests. Added additional ones along with an integration test.