chore!(create-turbo): remove old pm arg #8150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
turbo-orchestrator
bot
added
created-by: turborepo
pkg: create-turbo
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
tknickman
deleted the
tomknickman/turbo-3185-remove-create-turbo-package-manager-arg
branch
chris-olszewski
pushed a commit
that referenced
this pull request
May 20, 2024
### Description We replaced this with an option instead of an arg, but cleaning up here! ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
chris-olszewski
pushed a commit
that referenced
this pull request
May 22, 2024
### Description We replaced this with an option instead of an arg, but cleaning up here! ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
chris-olszewski
pushed a commit
that referenced
this pull request
May 28, 2024
### Description We replaced this with an option instead of an arg, but cleaning up here! ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description In #8150 we removed the deprecated package manager argument in favor of the option, but we didn't remove the corresponding parameter from the actual main function. This lead to the options object getting passed as the package manager argument and then the options object being undefined. ### Testing Instructions Before <img width="939" alt="Screenshot 2024-05-28 at 8 43 23 AM" src="https://github.com/vercel/turbo/assets/4131117/6dcaa4a7-b0e0-4142-9854-95ed597d4eb5"> After <img width="1171" alt="Screenshot 2024-05-28 at 8 43 01 AM" src="https://github.com/vercel/turbo/assets/4131117/7ef11479-5895-4cd4-838c-a26dcaa0529a"> --------- Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Anthony Shew <anthony.shew@vercel.com> Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Turbobot <turbobot@vercel.com>
chris-olszewski
pushed a commit
that referenced
this pull request
May 29, 2024
### Description We replaced this with an option instead of an arg, but cleaning up here! ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description In #8150 we removed the deprecated package manager argument in favor of the option, but we didn't remove the corresponding parameter from the actual main function. This lead to the options object getting passed as the package manager argument and then the options object being undefined. ### Testing Instructions Before <img width="939" alt="Screenshot 2024-05-28 at 8 43 23 AM" src="https://github.com/vercel/turbo/assets/4131117/6dcaa4a7-b0e0-4142-9854-95ed597d4eb5"> After <img width="1171" alt="Screenshot 2024-05-28 at 8 43 01 AM" src="https://github.com/vercel/turbo/assets/4131117/7ef11479-5895-4cd4-838c-a26dcaa0529a"> --------- Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Anthony Shew <anthony.shew@vercel.com> Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Turbobot <turbobot@vercel.com>
chris-olszewski
pushed a commit
that referenced
this pull request
May 31, 2024
### Description We replaced this with an option instead of an arg, but cleaning up here! ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description In #8150 we removed the deprecated package manager argument in favor of the option, but we didn't remove the corresponding parameter from the actual main function. This lead to the options object getting passed as the package manager argument and then the options object being undefined. ### Testing Instructions Before <img width="939" alt="Screenshot 2024-05-28 at 8 43 23 AM" src="https://github.com/vercel/turbo/assets/4131117/6dcaa4a7-b0e0-4142-9854-95ed597d4eb5"> After <img width="1171" alt="Screenshot 2024-05-28 at 8 43 01 AM" src="https://github.com/vercel/turbo/assets/4131117/7ef11479-5895-4cd4-838c-a26dcaa0529a"> --------- Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Anthony Shew <anthony.shew@vercel.com> Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Turbobot <turbobot@vercel.com>
chris-olszewski
pushed a commit
that referenced
this pull request
Jun 4, 2024
### Description We replaced this with an option instead of an arg, but cleaning up here! ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description In #8150 we removed the deprecated package manager argument in favor of the option, but we didn't remove the corresponding parameter from the actual main function. This lead to the options object getting passed as the package manager argument and then the options object being undefined. ### Testing Instructions Before <img width="939" alt="Screenshot 2024-05-28 at 8 43 23 AM" src="https://github.com/vercel/turbo/assets/4131117/6dcaa4a7-b0e0-4142-9854-95ed597d4eb5"> After <img width="1171" alt="Screenshot 2024-05-28 at 8 43 01 AM" src="https://github.com/vercel/turbo/assets/4131117/7ef11479-5895-4cd4-838c-a26dcaa0529a"> --------- Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Anthony Shew <anthony.shew@vercel.com> Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Turbobot <turbobot@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We replaced this with an option instead of an arg, but cleaning up here!
Testing Instructions