Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unbreak turborepo_2 #8183

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: unbreak turborepo_2 #8183

merged 1 commit into from
May 21, 2024

Conversation

chris-olszewski
Copy link
Member

Description

#8180 and #8157 ended up landing in a way where globs.t will fail due to using a test fixture that uses the now removed pipeline field.

Testing Instructions

CI

@chris-olszewski chris-olszewski marked this pull request as ready for review May 21, 2024 05:33
@vercel Vercel
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:33am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 21, 2024 5:33am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 21, 2024 5:33am
examples-gatsby-web ⬜️ Ignored (Inspect) May 21, 2024 5:33am
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 21, 2024 5:33am
examples-native-web ⬜️ Ignored (Inspect) May 21, 2024 5:33am
examples-svelte-web ⬜️ Ignored (Inspect) May 21, 2024 5:33am
examples-tailwind-web ⬜️ Ignored (Inspect) May 21, 2024 5:33am
examples-vite-web ⬜️ Ignored (Inspect) May 21, 2024 5:33am
rust-docs ⬜️ Ignored (Inspect) May 21, 2024 5:33am

@chris-olszewski chris-olszewski requested a review from a team as a code owner May 21, 2024 05:33
@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@tknickman tknickman merged commit bade972 into turborepo_2 May 21, 2024
53 checks passed
@tknickman tknickman deleted the olszewski/chore_fix_turborepo_2 branch May 21, 2024 13:09
chris-olszewski added a commit that referenced this pull request May 22, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
97ee648 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski added a commit that referenced this pull request May 28, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
f8043cd 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski added a commit that referenced this pull request May 29, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
acbe0f5 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski added a commit that referenced this pull request May 31, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
9780940 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski added a commit that referenced this pull request Jun 4, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
7c944a9 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang was automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
created-by: turborepo owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-olszewski @tknickman