Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Cargo.lock with Next.js #8246

Closed
wants to merge 2 commits into from
Closed

Sync Cargo.lock with Next.js #8246

wants to merge 2 commits into from

Conversation

wbinnssmith
Copy link
Member

Updates socket2, tokio, and tokio-macros

Updates socket2, tokio, and tokio-macros
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 29, 2024 8:05pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 29, 2024 8:05pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 8:05pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 29, 2024 8:05pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 8:05pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 8:05pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 8:05pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 8:05pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 8:05pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 8:05pm

Copy link
Contributor

github-actions bot commented May 29, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 29, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@chris-olszewski
Copy link
Member

For whatever reason tokio being at 1.37.0 breaks our Windows builds at the linking step. e.g.

This is something I want to get to the bottom of, but don't have the time to dedicate right now to figuring it out. Is the latest tokio version required for Next.js?

@wbinnssmith
Copy link
Member Author

For whatever reason tokio being at 1.37.0 breaks our Windows builds at the linking step. e.g.

This is something I want to get to the bottom of, but don't have the time to dedicate right now to figuring it out. Is the latest tokio version required for Next.js?

Looks like the reason it was update was to match turbo's, which isn't the case: vercel/next.js@99fff19

@bgw was this a mistake?

Copy link
Member

bgw commented May 30, 2024

Looks like the reason it was update was to match turbo's, which isn't the case: vercel/next.js@99fff19

@bgw was this a mistake?

Turbo was on 1.37.0 until yesterday: 7875ab2f67

@wbinnssmith
Copy link
Member Author

Closing in favor of vercel/next.js#66391

wbinnssmith added a commit to vercel/next.js that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants