Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC auto increase memory limit on inefficient GC #8687

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 8, 2024

Description

When GC is inefficient and can't collect enough memory, increase the provided memory limit automatically.
We rather want to consume more memory than requested then crashing or hanging the compilation due to GC.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 9:09pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 9:09pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jul 8, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jul 8, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Base automatically changed from sokra/excessive-cells to main July 24, 2024 19:40
GC until memory is reduced by 5%
increase memory limit when needed
@sokra sokra merged commit 4b34a31 into main Jul 25, 2024
56 of 59 checks passed
@sokra sokra deleted the sokra/gc-auto-increase branch July 25, 2024 15:32
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants