removes turbopack specific cargo commands #8924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
tknickman
approved these changes
Aug 1, 2024
| build = "build -p turbo" | ||
| run = "run -p turbo" | ||
| test = "groups test turborepo" | ||
| check = "groups check turborepo" |
There was a problem hiding this comment.
this isn't really necessary since the turborepo crates are the only ones left, so cargo test and cargo check will do the right thing
There was a problem hiding this comment.
oh, so are you saying we can just close this whole PR without merging it?
mehulkar
reviewed
Aug 2, 2024
Comment on lines
+38
to
+39
| test = "groups test turborepo" | ||
| check = "groups check turborepo" |
There was a problem hiding this comment.
Suggested change
| test = "groups test turborepo" | |
| check = "groups check turborepo" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with turbopack being removed in #8906, we can now simplify the root cargo commands (and remove the old turbopack ones)