-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch mode show limited error message for 'invalid task configuration' #8006
Comments
I am also seem to get the following message when not trying to run × failed to connect to daemon
╰─▶ server is unavailable: channel lagged by 2046 By running the command: If I run × failed to connect to daemon
╰─▶ server is unavailable: channel lagged by 1981 In the terminal that is running
Not sure why |
Looks like the error goes away when you only watch a few packages (3-4) but fails when you try to watch all your packages (60) |
Also looks like I think it might be mainly the process that gets started as:
I also have a lot of
|
I did find some daemon logs:
|
Hey, thanks for a very thorough and helpful issue! I have a PR up to improve the error messages, a bit of an oversight on my part not threading the proper error logic through. We're working on moving watch mode to a more stable foundation, which will hopefully eliminate the performance and lagging issues that you've noticed. |
Thank you, for taking the time to look into it! |
Hi @weyert, could you try the latest canary? We shipped some error handling and performance improvements. We should have some more coming very soon |
Sure! I only think the latest is still the |
Ah I have found |
Looks like it limited the number of Never noticed before, If I quite |
@NicholasLYang I can confirm the original issue is resolved in 1.3.3 only I haven't been to get pnpm exec turbo watch build --filter={packages/\*}
• Packages in scope: <snip>
• Running build in 36 packages
• Remote caching enabled
× failed to connect to daemon
╰─▶ server is unavailable: channel closed
pnpm exec turbo daemon status
✓ daemon is running
log file: /Users/xx/Development/Projects/monorepo/.turbo/daemon/f5b0831ce8ff9a15-turbo.log.2024-04-29
uptime: 2h 4m 42s 815mss
pid file: /var/folders/1m/4921_csd7gnddqdr0smhfqjh0000gn/T/turbod/f5b0831ce8ff9a15/turbod.pid
socket file: /var/folders/1m/4921_csd7gnddqdr0smhfqjh0000gn/T/turbod/f5b0831ce8ff9a15/turbod.sock
pnpm exec turbo watch build --filter={packages/\*}
• Packages in scope: <snip>
• Running build in 36 packages
• Remote caching enabled
× failed to connect to daemon
╰─▶ server is unavailable: channel closed |
Interesting. I have a bug fix out for watch mode. Could you send me the output of |
Sure, what’s your email address?
|
Hi @weyert, could you try the latest canary? It has some fixes for various issues along with some performance improvements and better change detection with file hashing |
I'm also seeing the
When this error occurs, there is only one new line in the daemon logs:
My env:
Should I start a separate thread, I wonder? |
We are receiving this as well in |
Hi, could you try running |
Before: |
Hi all, thanks for these reports. I'm gonna close out this issue, please feel free to open up a new issue with these bugs. |
Sorry, I'm uncertain of the logic of marking this issue completed. It's still occurring? |
Yes, the problem is still occurring, but this issue is originally for a completely different problem, so I'd prefer that we open a new issue with a more relevant title, so people can easily search and find it. |
I have created a new issue for the other problem discovered here: #8800 |
This solved my problem as well. Thank you! |
Verify canary release
Link to code that reproduces this issue
n/a
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
1.13.3-canary.3
Describe the Bug
When I run
turbo run dev
I am getting a different error message then when I runturbo watch dev
. The version of shown when usingrun
-command is more helpfulExpected Behavior
When running
turbo run dev
I am currently getting:while when running
turbo watch dev
only a part of the above message is outputted by the command, see:pnpm exec turbo watch dev × invalid task configuration
To Reproduce
You should be able to reproduce by trying to lowering the
turbo watch dev --concurrency=1
Additional context
No response
The text was updated successfully, but these errors were encountered: