Improved the now ls command
#1202
Conversation
|
With the help of @timneutkens, I also added source map support. Before: after: (notice the before-last lines in each stack trace) |
|
This can be merged once we polish list v3. It currently is missing |
| @@ -7,11 +7,15 @@ module.exports = { | |||
| entry: './src/now.js', | |||
| target: 'node', | |||
| externals: [nodeExternals()], | |||
| devtool: 'source-map', | |||
There was a problem hiding this comment.
@rauchg, just curious (as I was enabling source map support myself for fixing #1010): doesn't this devtoolsetting mean that source maps are always generated, even in production? Looking at https://webpack.js.org/configuration/devtool/ this setting is ok for production, but in your commit message you wrote something about (small) performance hits and that you only want to enable source maps in development.
There was a problem hiding this comment.
My approach was around something like:
const isDev = process.env.NODE_ENV === 'development';
module.exports = {
entry: './src/now.js',
devtool: isDev ? 'source-map' : false,
// [...](... or introducing https://github.com/kentcdodds/webpack-config-utils if more prod/dev differences within the webpack config pop up.)
|
Closing in favor of #1205 |
mainfunction with return values (Instead of usingawait exit()or invokingprocess.exit()directly, use return values #1194)>color in> Error!outputavato0.xso that it doesn't bring babel 7now.jsrefactored to useexitutilityEPIPEfixes now apply to the entire codebasecwd' (only worked for package.json)now domains lsalso renderageinstead ofcreatedfor consistencynow lsonly shows the latest deployment per app now.now ls [app]shows allnow ls --allis much faster by skipping trying to get instances wheninstanceCount = 0(the field was introduced by v3 of list API)