Rework prefetch route handling #10779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a3f9ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…el into ijjk/reworker-prefetch-index
ijjk
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi,
Ethan-Arrowood,
trek and
ztanner
as code owners
Ethan-Arrowood
approved these changes
Oct 31, 2023
|
It hasn't been rolled yet/isn't officially supported by our proxy so this removes the broken behavior before we do roll it out |
Merged
Ethan-Arrowood
pushed a commit
that referenced
this pull request
Nov 7, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@7.2.3 ### Patch Changes - Add experimental flag to allow Node.js v20 ([#10802](#10802)) ## vercel@32.5.1 ### Patch Changes - Debug log load user exceptions ([#10773](#10773)) - bump: edge-runtime ([#10712](#10712)) - Updated dependencies \[[`fc90a3dc0`](fc90a3d), [`644b8a52c`](644b8a5), [`0861dc8fb`](0861dc8), [`33cc8e0ac`](33cc8e0), [`f5296c3c0`](f5296c3), [`d9065c210`](d9065c2)]: - @vercel/next@4.0.12 - @vercel/node@3.0.8 - @vercel/build-utils@7.2.3 - @vercel/remix-builder@2.0.11 - @vercel/static-build@2.0.10 ## @vercel/client@13.0.7 ### Patch Changes - Updated dependencies \[[`0861dc8fb`](0861dc8)]: - @vercel/build-utils@7.2.3 ## @vercel/edge@1.1.1 ### Patch Changes - bump: edge-runtime ([#10712](#10712)) ## @vercel/error-utils@2.0.2 ### Patch Changes - use Node.js `util.types.isNativeError` for `isError` method ([#10764](#10764)) ## @vercel/frameworks@2.0.3 ### Patch Changes - update Angular output path discovery ([#10678](#10678)) - Updated dependencies \[[`34dd9c091`](34dd9c0)]: - @vercel/error-utils@2.0.2 ## @vercel/fs-detectors@5.1.3 ### Patch Changes - Updated dependencies \[[`306f653da`](306f653), [`34dd9c091`](34dd9c0)]: - @vercel/frameworks@2.0.3 - @vercel/error-utils@2.0.2 ## @vercel/gatsby-plugin-vercel-builder@2.0.9 ### Patch Changes - Fix nested SSR routes ([#10751](#10751)) - Updated dependencies \[[`0861dc8fb`](0861dc8)]: - @vercel/build-utils@7.2.3 ## @vercel/next@4.0.12 ### Patch Changes - fix re-mapping logic for index prefetches ([#10750](#10750)) - Fixes a case where using `basePath` along with static generation would output a lambda that conflicts with the root route. ([#10738](#10738)) - Rework prefetch route handling ([#10779](#10779)) ## @vercel/node@3.0.8 ### Patch Changes - bump: edge-runtime ([#10712](#10712)) - Updated dependencies \[[`0861dc8fb`](0861dc8), [`34dd9c091`](34dd9c0)]: - @vercel/build-utils@7.2.3 - @vercel/error-utils@2.0.2 ## @vercel/remix-builder@2.0.11 ### Patch Changes - Update `@remix-run/dev` fork to v2.2.0 ([#10788](#10788)) ## @vercel/static-build@2.0.10 ### Patch Changes - Updated dependencies \[[`efd3cc05d`](efd3cc0)]: - @vercel/gatsby-plugin-vercel-builder@2.0.9 ## @vercel-internals/types@1.0.14 ### Patch Changes - Updated dependencies \[[`0861dc8fb`](0861dc8)]: - @vercel/build-utils@7.2.3 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10750 this removes the underscore prefetching from all prefetch outputs and instead only applies it to the index route itself as this causes issues with PPR making these outputs prerenders and being able to interpolate the route param values.
There is the edge case of a user returning the literal value
indexfromgenerateStaticParamsbut we can tolerate that more than ppr not working as expected.