-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Angular output path discovery #10678
Conversation
🦋 Changeset detectedLatest commit: 9365b4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@alan-agius4 Thanks! We're taking a look and plan to have support ready for Angular 17 before the release date. |
Opened #10705 just get our tests to run (it's silly but how we do this right now) |
@alan-agius4 looks like we're good to merge. Both @EndangeredMassa and I saw a green suite on the PR we opened to get tests to run. I'm not sure why or how this commit appears on your branch on your fork, but it needs to be removed since it adds a second changeset file to the PR. |
Angular CLI version 17 new esbuild and vite builder will output resources files to . This change updates the method to handle this.
@trek, I have removed the extra commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually tested v16 and v17 before and after this change. Looks good!
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@7.2.3 ### Patch Changes - Add experimental flag to allow Node.js v20 ([#10802](#10802)) ## vercel@32.5.1 ### Patch Changes - Debug log load user exceptions ([#10773](#10773)) - bump: edge-runtime ([#10712](#10712)) - Updated dependencies \[[`fc90a3dc0`](fc90a3d), [`644b8a52c`](644b8a5), [`0861dc8fb`](0861dc8), [`33cc8e0ac`](33cc8e0), [`f5296c3c0`](f5296c3), [`d9065c210`](d9065c2)]: - @vercel/next@4.0.12 - @vercel/node@3.0.8 - @vercel/build-utils@7.2.3 - @vercel/remix-builder@2.0.11 - @vercel/static-build@2.0.10 ## @vercel/client@13.0.7 ### Patch Changes - Updated dependencies \[[`0861dc8fb`](0861dc8)]: - @vercel/build-utils@7.2.3 ## @vercel/edge@1.1.1 ### Patch Changes - bump: edge-runtime ([#10712](#10712)) ## @vercel/error-utils@2.0.2 ### Patch Changes - use Node.js `util.types.isNativeError` for `isError` method ([#10764](#10764)) ## @vercel/frameworks@2.0.3 ### Patch Changes - update Angular output path discovery ([#10678](#10678)) - Updated dependencies \[[`34dd9c091`](34dd9c0)]: - @vercel/error-utils@2.0.2 ## @vercel/fs-detectors@5.1.3 ### Patch Changes - Updated dependencies \[[`306f653da`](306f653), [`34dd9c091`](34dd9c0)]: - @vercel/frameworks@2.0.3 - @vercel/error-utils@2.0.2 ## @vercel/gatsby-plugin-vercel-builder@2.0.9 ### Patch Changes - Fix nested SSR routes ([#10751](#10751)) - Updated dependencies \[[`0861dc8fb`](0861dc8)]: - @vercel/build-utils@7.2.3 ## @vercel/next@4.0.12 ### Patch Changes - fix re-mapping logic for index prefetches ([#10750](#10750)) - Fixes a case where using `basePath` along with static generation would output a lambda that conflicts with the root route. ([#10738](#10738)) - Rework prefetch route handling ([#10779](#10779)) ## @vercel/node@3.0.8 ### Patch Changes - bump: edge-runtime ([#10712](#10712)) - Updated dependencies \[[`0861dc8fb`](0861dc8), [`34dd9c091`](34dd9c0)]: - @vercel/build-utils@7.2.3 - @vercel/error-utils@2.0.2 ## @vercel/remix-builder@2.0.11 ### Patch Changes - Update `@remix-run/dev` fork to v2.2.0 ([#10788](#10788)) ## @vercel/static-build@2.0.10 ### Patch Changes - Updated dependencies \[[`efd3cc05d`](efd3cc0)]: - @vercel/gatsby-plugin-vercel-builder@2.0.9 ## @vercel-internals/types@1.0.14 ### Patch Changes - Updated dependencies \[[`0861dc8fb`](0861dc8)]: - @vercel/build-utils@7.2.3 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Angular CLI version 17 new esbuild and vite builder will output resources files to
dist/<project-name>/browser
.This change updates the
getOutputDirName
method to handle this.