Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error-utils] use Node.js util.types.isNativeError for isError method #10764

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

Ethan-Arrowood
Copy link
Contributor

I recently learned about https://nodejs.org/api/util.html#utiltypesisnativeerrorvalue which is pretty great. It will return true for all errors including subclasses (class MyError extends Error {})

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: db8aed8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@vercel/error-utils Patch
vercel Patch
@vercel/frameworks Patch
@vercel/fs-detectors Patch
@vercel/node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

TooTallNate
TooTallNate previously approved these changes Oct 24, 2023
cb1kenobi
cb1kenobi previously approved these changes Oct 24, 2023
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato

trek
trek previously approved these changes Oct 25, 2023
TooTallNate
TooTallNate previously approved these changes Oct 31, 2023
@TooTallNate TooTallNate added the pr: automerge Automatically merge the PR when checks pass label Oct 31, 2023
@kodiakhq kodiakhq bot merged commit 34dd9c0 into main Oct 31, 2023
19 checks passed
@kodiakhq kodiakhq bot deleted the use-isnativeerror branch October 31, 2023 19:39
Ethan-Arrowood pushed a commit that referenced this pull request Nov 7, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/build-utils@7.2.3

### Patch Changes

- Add experimental flag to allow Node.js v20
([#10802](#10802))

## vercel@32.5.1

### Patch Changes

- Debug log load user exceptions
([#10773](#10773))

- bump: edge-runtime
([#10712](#10712))

- Updated dependencies
\[[`fc90a3dc0`](fc90a3d),
[`644b8a52c`](644b8a5),
[`0861dc8fb`](0861dc8),
[`33cc8e0ac`](33cc8e0),
[`f5296c3c0`](f5296c3),
[`d9065c210`](d9065c2)]:
    -   @vercel/next@4.0.12
    -   @vercel/node@3.0.8
    -   @vercel/build-utils@7.2.3
    -   @vercel/remix-builder@2.0.11
    -   @vercel/static-build@2.0.10

## @vercel/client@13.0.7

### Patch Changes

- Updated dependencies
\[[`0861dc8fb`](0861dc8)]:
    -   @vercel/build-utils@7.2.3

## @vercel/edge@1.1.1

### Patch Changes

- bump: edge-runtime
([#10712](#10712))

## @vercel/error-utils@2.0.2

### Patch Changes

- use Node.js `util.types.isNativeError` for `isError` method
([#10764](#10764))

## @vercel/frameworks@2.0.3

### Patch Changes

- update Angular output path discovery
([#10678](#10678))

- Updated dependencies
\[[`34dd9c091`](34dd9c0)]:
    -   @vercel/error-utils@2.0.2

## @vercel/fs-detectors@5.1.3

### Patch Changes

- Updated dependencies
\[[`306f653da`](306f653),
[`34dd9c091`](34dd9c0)]:
    -   @vercel/frameworks@2.0.3
    -   @vercel/error-utils@2.0.2

## @vercel/gatsby-plugin-vercel-builder@2.0.9

### Patch Changes

- Fix nested SSR routes
([#10751](#10751))

- Updated dependencies
\[[`0861dc8fb`](0861dc8)]:
    -   @vercel/build-utils@7.2.3

## @vercel/next@4.0.12

### Patch Changes

- fix re-mapping logic for index prefetches
([#10750](#10750))

- Fixes a case where using `basePath` along with static generation would
output a lambda that conflicts with the root route.
([#10738](#10738))

- Rework prefetch route handling
([#10779](#10779))

## @vercel/node@3.0.8

### Patch Changes

- bump: edge-runtime
([#10712](#10712))

- Updated dependencies
\[[`0861dc8fb`](0861dc8),
[`34dd9c091`](34dd9c0)]:
    -   @vercel/build-utils@7.2.3
    -   @vercel/error-utils@2.0.2

## @vercel/remix-builder@2.0.11

### Patch Changes

- Update `@remix-run/dev` fork to v2.2.0
([#10788](#10788))

## @vercel/static-build@2.0.10

### Patch Changes

- Updated dependencies
\[[`efd3cc05d`](efd3cc0)]:
    -   @vercel/gatsby-plugin-vercel-builder@2.0.9

## @vercel-internals/types@1.0.14

### Patch Changes

- Updated dependencies
\[[`0861dc8fb`](0861dc8)]:
    -   @vercel/build-utils@7.2.3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Automatically merge the PR when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants