[next]: skip action rewrite if RSC header is present #11576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e88583c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ztanner
commented
May 10, 2024
| @@ -1956,14 +1956,20 @@ export async function serverBuild({ | |||
| // Also includes separate handling for index routes which should match to /index.action. | |||
| // This follows the same pattern as the rewrites for .rsc files. | |||
| { | |||
| src: `^${path.posix.join('/', entryDirectory, '/')}`, | |||
| src: `^${path.posix.join('/', entryDirectory, '/?')}`, | |||
There was a problem hiding this comment.
Unrelated to the core change here, but I updated this to match the same change for RSC handling in this PR, since it seems relevant to both cases:
ztanner
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom,
jeffsee55,
erikareads,
timneutkens,
ijjk,
huozhi,
Ethan-Arrowood and
styfle
as code owners
ijjk
approved these changes
May 10, 2024
ztanner
added
pr: automerge
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
May 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@8.1.0 ### Minor Changes - Update pnpm version detection logic ([#11445](#11445)) Add support for pnpm 9 ## vercel@34.1.11 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e), [`18d1703d5`](18d1703), [`e87d4c14d`](e87d4c1), [`bc5fd4115`](bc5fd41)]: - @vercel/build-utils@8.1.0 - @vercel/next@4.2.10 - @vercel/redwood@2.0.9 - @vercel/remix-builder@2.1.6 - @vercel/node@3.1.1 - @vercel/static-build@2.5.5 ## @vercel/client@13.2.3 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 ## @vercel/gatsby-plugin-vercel-builder@2.0.27 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 ## @vercel/next@4.2.10 ### Patch Changes - skip action rewrites for RSC requests ([#11576](#11576)) - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) ## @vercel/node@3.1.1 ### Patch Changes - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 ## @vercel/redwood@2.0.9 ### Patch Changes - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) ## @vercel/remix-builder@2.1.6 ### Patch Changes - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) - Update `@remix-run/dev` fork to v2.9.2-patch.2 ([#11582](#11582)) ## @vercel/static-build@2.5.5 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.27 ## @vercel-internals/types@1.0.32 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rewriting requests that contain a
next-actionheader to a.actionoutput, we should do so only in the case where the RSC header isn't present. When a Next.js server action triggers aredirect, an intra-app RSC request will be made to that requested URL, with thenext-actionheader still present. This means the intra-app request will be incorrectly rewritten, when we only intended to handle the actual action request.This was patched in Next.js in the following PR:
But it seems like a good idea to be resilient to this here as well.