[cli] Collect diagnostics from builders during vc build
#11653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3fba506 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.changeset/hot-rules-tickle.md
Outdated
| 'vercel': minor | ||
| --- | ||
|
|
||
| Output "diagnostics" directory during `vc build` |
There was a problem hiding this comment.
It would be great to have some tests around this logic
There was a problem hiding this comment.
@TooTallNate Could you help with setting up some test?
ofhouse
changed the title
vc buildvc build
ofhouse
requested review from
trek,
onsclom,
jeffsee55,
erikareads,
timneutkens,
ijjk,
ztanner,
huozhi and
Ethan-Arrowood
as code owners
trek
approved these changes
Jul 1, 2024
feugy
pushed a commit
that referenced
this pull request
Jul 2, 2024
Adds the ability for builders to define a `diagnostics` step that is called after the build operation is done (either failed or successful). Implements the diagnostics step in the next builder. **References** - vercel/next.js#66187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for builders to define a
diagnosticsstep that is called after the build operation is done (either failed or successful).Implements the diagnostics step in the next builder.
References