-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[now-build-utils] Add types for SPRv2 #3021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
approved these changes
Sep 15, 2019
AndyBitz
approved these changes
Sep 15, 2019
AndyBitz
reviewed
Sep 15, 2019
Codecov Report
@@ Coverage Diff @@
## canary #3021 +/- ##
==========================================
+ Coverage 11.33% 13.36% +2.03%
==========================================
Files 267 267
Lines 10032 10273 +241
Branches 1308 1216 -92
==========================================
+ Hits 1137 1373 +236
- Misses 8803 8838 +35
+ Partials 92 62 -30
Continue to review full report at Codecov.
|
styfle
approved these changes
Sep 16, 2019
juancampa
reviewed
Sep 16, 2019
styfle
pushed a commit
that referenced
this pull request
Sep 17, 2019
* Add `Prerender` type for SPRv2 * Make it a default export * Added `PrerenderGroup` type * Renamed interface
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 29, 2019
Adds support for new SPRv2 handling in Next.js. x-ref: #3021
leo
pushed a commit
that referenced
this pull request
Nov 11, 2019
Adds support for new SPRv2 handling in Next.js. x-ref: #3021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two new types in preparation for Serverless Prerendering v2.
The first one is
Prerender
, which represents a pre-rendering bundle:The second one is
PrerenderGroup
, which defines a list ofPrerender
that should be invalidated at the same time – if one of them is invalidated: