Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-build-utils] Add types for SPRv2 #3021

Merged
merged 5 commits into from Sep 17, 2019
Merged

[now-build-utils] Add types for SPRv2 #3021

merged 5 commits into from Sep 17, 2019

Conversation

leo
Copy link
Contributor

@leo leo commented Sep 15, 2019

This pull request adds two new types in preparation for Serverless Prerendering v2.

The first one is Prerender, which represents a pre-rendering bundle:

interface Prerender {
  expiration: number;
  lambda: Lambda;
  fallback: FileBlob | FileFsRef | FileRef;
}

The second one is PrerenderGroup, which defines a list of Prerender that should be invalidated at the same time – if one of them is invalidated:

interface PrerenderGroup {
  items: Array<Prerender>;
}

@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #3021 into canary will increase coverage by 2.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3021      +/-   ##
==========================================
+ Coverage   11.33%   13.36%   +2.03%     
==========================================
  Files         267      267              
  Lines       10032    10273     +241     
  Branches     1308     1216      -92     
==========================================
+ Hits         1137     1373     +236     
- Misses       8803     8838      +35     
+ Partials       92       62      -30
Impacted Files Coverage Δ
src/util/dev/builder-cache.ts 80.74% <0%> (+3.47%) ⬆️
src/util/get-files.ts 91.66% <0%> (+3.88%) ⬆️
src/util/dev/router.ts 82.69% <0%> (+4.12%) ⬆️
src/util/dev/builder.ts 77.41% <0%> (+4.34%) ⬆️
src/util/dev/yarn-installer.ts 90.74% <0%> (+5.02%) ⬆️
src/util/dev/server.ts 66.43% <0%> (+5.73%) ⬆️
src/util/output/create-output.ts 43.58% <0%> (+12.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502f78e...6b40318. Read the comment docs.

@leo leo changed the title Add Prerender type for SPRv2 Add types for SPRv2 Sep 16, 2019
@leo leo changed the title Add types for SPRv2 Added types for SPRv2 Sep 16, 2019
@leo leo changed the title Added types for SPRv2 Add types for SPRv2 Sep 16, 2019
@styfle styfle changed the title Add types for SPRv2 [now-build-utils] Add types for SPRv2 Sep 16, 2019
@leo leo added the automerge label Sep 17, 2019
@kodiakhq kodiakhq bot merged commit 81c2777 into canary Sep 17, 2019
@kodiakhq kodiakhq bot deleted the add-spr-type branch September 17, 2019 18:28
styfle pushed a commit that referenced this pull request Sep 17, 2019
* Add `Prerender` type for SPRv2

* Make it a default export

* Added `PrerenderGroup` type

* Renamed interface
kodiakhq bot pushed a commit that referenced this pull request Oct 29, 2019
Adds support for new SPRv2 handling in Next.js.

x-ref: #3021
leo pushed a commit that referenced this pull request Nov 11, 2019
Adds support for new SPRv2 handling in Next.js.

x-ref: #3021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants