Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli][redwood] Update redwood port detection in vc dev #4937

Merged
merged 8 commits into from
Jul 31, 2020
Merged

[cli][redwood] Update redwood port detection in vc dev #4937

merged 8 commits into from
Jul 31, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Jul 27, 2020

Fixes redwood support for vc dev

@styfle styfle requested a review from TooTallNate July 27, 2020 23:17
@styfle styfle changed the title [cli][redwood] Read redwood.toml for dev port [cli][redwood] Update redwood port in vc dev Jul 28, 2020
styfle
styfle commented Jul 28, 2020
View reviewed changes
.github/workflows/publish.yml Outdated Show resolved Hide resolved
styfle
styfle commented Jul 28, 2020
View reviewed changes
.github/workflows/publish.yml Outdated Show resolved Hide resolved
TooTallNate
TooTallNate previously approved these changes Jul 28, 2020
View reviewed changes
@styfle styfle requested a review from TooTallNate July 28, 2020 21:18
TooTallNate
TooTallNate previously approved these changes Jul 30, 2020
View reviewed changes
@styfle styfle changed the title [cli][redwood] Update redwood port in vc dev [cli][redwood] Update redwood port detection in vc dev Jul 30, 2020
@styfle styfle requested a review from TooTallNate July 30, 2020 22:43
@kodiakhq kodiakhq bot merged commit 1c96071 into master Jul 31, 2020
@kodiakhq kodiakhq bot deleted the ch1718/rw-dev-special branch July 31, 2020 13:14
@styfle styfle mentioned this pull request Aug 13, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 13, 2020
@styfle
[cli][redwood] Update frontend framework detection in vc dev (#5036)
6bb162e 
This PR uses the the new property added in PR #5034 to determine if a framework has a frontend runtime defined.

It also reverts a couple workarounds add in PR #4937 which was added for RedwoodJS which is no longer necessary since RedwoodJS defines a frontend framework the same way Next.js does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@AndyBitz AndyBitz AndyBitz approved these changes

@mcsdevv mcsdevv Awaiting requested review from mcsdevv

@timothyis timothyis Awaiting requested review from timothyis

Assignees
No one assigned
Labels
area: cli area: dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@styfle @TooTallNate @AndyBitz