-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build-utils][frameworks] Add support for runtime properties #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c1b70cb.
TooTallNate
reviewed
Aug 13, 2020
TooTallNate
approved these changes
Aug 13, 2020
AndyBitz
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two properties to
frameworks.json
:useRuntime
- this moves the special case for non@vercel/static-build
frontends, so that any framework can do the same as Next.js and RedwoodJSignoreRuntimes
- this allows a framework to opt out of api detection such as RedwoodJS which handle's its own.js
extensionsThis also fixes 2 bugs discovered during implementing the feature:
test-unit.yml
was not testing Node 12, it was testing 10 for both runssortFilesBySegmentCount()
was non-deterministic causing node 10 and 12 to sort differently