Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-utils][frameworks] Add support for runtime properties #5034

Merged
merged 9 commits into from
Aug 13, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 13, 2020

This PR adds two properties to frameworks.json:

  1. useRuntime - this moves the special case for non @vercel/static-build frontends, so that any framework can do the same as Next.js and RedwoodJS
  2. ignoreRuntimes - this allows a framework to opt out of api detection such as RedwoodJS which handle's its own .js extensions

This also fixes 2 bugs discovered during implementing the feature:

  1. test-unit.yml was not testing Node 12, it was testing 10 for both runs
  2. sortFilesBySegmentCount() was non-deterministic causing node 10 and 12 to sort differently

@styfle styfle marked this pull request as ready for review August 13, 2020 18:39
@styfle styfle requested a review from AndyBitz as a code owner August 13, 2020 18:39
@kodiakhq kodiakhq bot merged commit 1f4f2af into master Aug 13, 2020
@kodiakhq kodiakhq bot deleted the ch1718/rw-zero-conf branch August 13, 2020 19:18
kodiakhq bot pushed a commit that referenced this pull request Aug 13, 2020
This PR uses the the new property added in PR #5034 to determine if a framework has a frontend runtime defined.

It also reverts a couple workarounds add in PR #4937 which was added for RedwoodJS which is no longer necessary since RedwoodJS defines a frontend framework the same way Next.js does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants