[cli][redwood] Update frontend framework detection in vc dev
#5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
changed the title
vc dev
TooTallNate
reviewed
Aug 13, 2020
TooTallNate
reviewed
Aug 13, 2020
TooTallNate
reviewed
Aug 13, 2020
Co-authored-by: Nathan Rajlich <n@n8.io>
TooTallNate
approved these changes
Aug 13, 2020
MaxLeiter
approved these changes
Aug 13, 2020
styfle
added a commit
that referenced
this pull request
Aug 14, 2020
The CLI doesn't depend on `@vercel/redwood` for `vc dev` since PR #5036 so we can remove it. Similarly, zero config does not install `@vercel/next` or `@vercel/static-build` during `vc dev` so these can be removed too. In the case where the user defines `builds` in vercel.json, the runtimes will be installed during the first run of `vc dev`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the the new property added in PR #5034 to determine if a framework has a frontend runtime defined.
It also reverts a couple workarounds add in PR #4937 which was added for RedwoodJS which is no longer necessary since RedwoodJS defines a frontend framework the same way Next.js does.