Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Remove initial iteration of vc build and Plugins #7390

Merged
merged 8 commits into from
Feb 15, 2022

Conversation

TooTallNate
Copy link
Member

The vercel build command is being restructured, so we'll remove it for now so that this initial iteration isn't included as part of the stable CLI release.

The `vercel build` command is being restructured, so we'll remove it for
now so that this initial iteration isn't included as part of the stable
CLI release.
@TooTallNate TooTallNate marked this pull request as draft February 4, 2022 09:30
Co-authored-by: Steven <steven@ceriously.com>
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also remove the .output change to .gitignore

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #7390 (3fc6ad2) into main (59e4572) will decrease coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7390      +/-   ##
==========================================
- Coverage   49.45%   48.57%   -0.88%     
==========================================
  Files         134      132       -2     
  Lines        5381     5295      -86     
  Branches     1350     1328      -22     
==========================================
- Hits         2661     2572      -89     
- Misses       2707     2710       +3     
  Partials       13       13              
Impacted Files Coverage Δ
packages/cli/src/util/dev/server.ts 58.53% <ø> (-0.89%) ⬇️
packages/cli/src/util/projects/link.ts 58.33% <ø> (+0.73%) ⬆️
packages/cli/src/util/dev/errors.ts 71.42% <0.00%> (-21.43%) ⬇️
packages/cli/src/util/dev/builder-cache.ts 77.10% <0.00%> (-5.61%) ⬇️
packages/cli/src/util/output/color-name-cache.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e4572...3fc6ad2. Read the comment docs.

Copy link
Contributor

@EndangeredMassa EndangeredMassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of references to vercel build in comments, but I don't think it's blocking.

  • packages/cli/src/util/projects/project-settings.ts
  • packages/build-utils/src/detect-file-system-api.ts

@TooTallNate TooTallNate added area: cli semver: major PR contains breaking changes labels Feb 14, 2022
@TooTallNate TooTallNate merged commit 9839466 into main Feb 15, 2022
@TooTallNate TooTallNate deleted the remove/vc-buld-fs-api branch February 15, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: major PR contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants