Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update node within Dockerfile #1139

Merged
merged 3 commits into from
Dec 4, 2018
Merged

fix: update node within Dockerfile #1139

merged 3 commits into from
Dec 4, 2018

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Nov 26, 2018 •
edited
Loading

Node.js will release a security patch today (27tn Nov)

This PR will update the Docker image base to the latest version available.

⚠️ https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/

@juanpicado juanpicado added this to the 3.x.x milestone Nov 26, 2018
@juanpicado juanpicado requested review from ayusharma and a team November 26, 2018 18:46
ayusharma
ayusharma previously requested changes Nov 27, 2018
View reviewed changes
Copy link
Member

@ayusharma ayusharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we are waiting for some date..

@juanpicado
Copy link
Member Author

https://nodejs.org/en/download/ node 10.0.14 was released, but the alpine node tag is not yet available, waiting for it for next release.

@juanpicado juanpicado dismissed ayusharma’s stale review December 4, 2018 07:50

alpine 10.0.14 was released already

@juanpicado juanpicado merged commit 24e9121 into master Dec 4, 2018
@delete-merged-branch delete-merged-branch bot deleted the update-docker branch December 4, 2018 18:09
@lock
Copy link

lock bot commented Mar 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayusharma ayusharma ayusharma approved these changes

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees
No one assigned
Labels
dev: code-review Docker
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@juanpicado @ayusharma @priscilawebdev