Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing away with __Trace.cpp and __Trace__Slow.cpp files #3033

Closed
gezalore opened this issue Jun 19, 2021 · 1 comment
Closed

Doing away with __Trace.cpp and __Trace__Slow.cpp files #3033

gezalore opened this issue Jun 19, 2021 · 1 comment
Labels
resolution: abandoned Closed; not enough information or otherwise never finished

Comments

@gezalore
Copy link
Member

Currently the trace functions are emitted in a separate pass primarilly because they are magic and EmitC adds a bit of extra text at the top of the trace functions. I would like to get rid of this and add any text necessary into the function bodies via AstText and friends so Emit does not need to know.

This would mean trace and implementation fucntions could be emitted by the same pass. The only question I have is whether we would like to keep the __Trace substring in the file names, or can we just put trace and implementation functions together ? Apart from reading the file names/build output, this makes no difference today at all. Fast/slow code would still be separate of course.

@gezalore gezalore added the new New issue not seen by maintainers label Jun 19, 2021
@wsnyder wsnyder added status: discussion Issue is waiting for discussions to resolve and removed new New issue not seen by maintainers labels Jun 19, 2021
@gezalore
Copy link
Member Author

I think it will not be too difficult/detrimental to keep the filenames, so I am closing this for now. might reopen if that thinking changes.

@gezalore gezalore added resolution: abandoned Closed; not enough information or otherwise never finished and removed status: discussion Issue is waiting for discussions to resolve labels Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: abandoned Closed; not enough information or otherwise never finished
Projects
None yet
Development

No branches or pull requests

2 participants