WIFEXITED missing from MinGW/MSYS2, added defines #2609
Conversation
There was a problem hiding this comment.
Thanks for contributing these fixes.
Are you sure there isn't some other include with the proper definitions?
If not, is the pointer stuff required? On Linux's /usr/include/waitstatus.h after removing an extra level of defines it's just e.g.
define WTERMSIG(stat) ((stat) & 0x7f)
|
I tried to import something else, but the only other hit I've got for these defines in my MSYS2 directory is from tclWinPort.h from tcl 8.6. I just copied those. |
thebrave
force-pushed
the
fix-mingw-compilation
branch
from
2f7b782
to
0a14a0d
Compare
…h less pointer manipulation.
|
Found another source of that macro on Win32 in the binutils-gdb repository. Same magic numbers, but binutils is a very reputable source and they explain the how they got to those numbers by pointing at defines in Microsoft's headers. Also removed defines we don't directly need. |
|
Thanks for updating, and making your first pull. |
Following on #2353, I'm creating a pull request to add W* defines that are missing on MinGW/MSYS2.
I don't think tests can be run on MSYS2/MinGW (perl runner prerequisites can't be installed), but I did a manual check by verilating a simple design.