Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODIN II: dual_port_ram memory depth not bounded #3

Closed
kmurray opened this issue Jun 26, 2015 · 4 comments
Closed

ODIN II: dual_port_ram memory depth not bounded #3

kmurray opened this issue Jun 26, 2015 · 4 comments
Assignees

Comments

@kmurray
Copy link
Contributor

kmurray commented Jun 26, 2015

Originally reported on Google Code with ID 10

What steps will reproduce the problem?
1. ./odin_II.exe -V test3.v -a sample_arch.xml 
2.
3.

What is the expected output? What do you see instead?
addr input width to dual_port_ram should be bounded.
Instead, overflow occurs:

Hard Logical Memory Distribution
============================
DPRAM: 32 width 26 depth

Total Logical Memory Blocks = 1 
Total Logical Memory bits = -2147483648 
Max Memory Width = 32 
Max Memory Depth = 26

and ODIN II eats up lots of memory during the "Performing Optimizations of the Netlist"
stage.


What version of the product are you using? On what operating system?
ODIN II version 0.1 (from VTR1.0rc1) under 64-bit Linux

Please provide any additional information below.


Reported by eddie.hung on 2012-01-20 01:08:30


- _Attachment: [test3.v](https://storage.googleapis.com/google-code-attachments/vtr-verilog-to-routing/issue-10/comment-0/test3.v)_ - _Attachment: [sample_arch.xml](https://storage.googleapis.com/google-code-attachments/vtr-verilog-to-routing/issue-10/comment-0/sample_arch.xml)_
@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Reported by jeffrey.goeders on 2012-01-20 18:17:53

  • Labels added: Module-ODIN

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Thank you for reporting this issue and helping improve ODIN II!

The memories are undergoing a major overhaul now. I have fixed the overflow problem
in the printout in my local version and it will be released to SVN as soon as we've
published our results. 

The depth ODIN II can handle depends on what optimizations you are doing, the amount
of RAM in your machine and which architecture you are mapping to. In your case, ODIN
II was splitting all memories down to a data width of 1, which resulted in poor mapping
performance on such a large memory block. If you remove the class="memory" from the
memory specifications in the architecture file you supplied, it will prevent ODIN II
from splitting all the memories down to 1 bit data. Then the compilation will succeed.



Reported by andy16666 on 2012-04-05 14:01:37

@kmurray kmurray self-assigned this Jun 26, 2015
@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Reported by andy16666 on 2012-04-05 14:09:41

  • Status changed: Fixed

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Added a configurable bound to memories.h. 

Reported by andy16666 on 2012-04-05 14:40:29

@kmurray kmurray closed this as completed Jun 26, 2015
kmurray added a commit that referenced this issue Apr 2, 2018
1fc200f Merge pull request #7 from sterin/master
9c78efb Makefile: add support for ABC_USE_STDINT_H
4a39f32 Merge pull request #2 from rqou/master
8d472cd Rename new flag to ABC_USE_STDINT_H
d879336 Merge pull request #5 from sterin/master
c5aebf6 README: minor updates
2fd7ba5 Merge pull request #1 from gpshead/patch-1
41eb4ea Merge pull request #3 from kmurray/fix_cmake_libabc_dependency
c3be5dc CMake: Ensure abc executable depends on libabc
40c8a39 Add an option to use C99 stdint.h
ce4b3cf point to github instead of bitbucket

git-subtree-dir: abc
git-subtree-split: 1fc200ffacabed1796639b562181051614f5fedb
litghost added a commit to litghost/vtr-verilog-to-routing that referenced this issue Oct 24, 2018
@vaughnbetz vaughnbetz mentioned this issue Jul 24, 2020
7 tasks
vaughnbetz pushed a commit that referenced this issue Jul 30, 2020
vaughnbetz pushed a commit that referenced this issue Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant