Initial place matrix serialization/deserialization support. #989
Conversation
- Adds library for handling capnp files and generic NdMatrix support. Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
probot-autolabeler
bot
added
build
| VPR_THROW(VPR_ERROR_ROUTE, "DeltaDelayModel::write unimplemented"); | ||
| void read(const std::string& file) override; | ||
| void write(const std::string& file) const override; | ||
| const vtr::Matrix<float>& delays() const { |
There was a problem hiding this comment.
Is it necessary to expose this implementation detail? Part of the motivation for making the PlaceDelayModel interface was to hide details like this.
There was a problem hiding this comment.
The reason was ease of implementation of OverrideDelayModel serialization, see #989 (comment)
I know how to remove this method if needed, but it is really about what to do about #989 (comment) that changes what the "solution" is here.
| private: | ||
| std::unique_ptr<PlaceDelayModel> base_delay_model_; | ||
| std::unique_ptr<DeltaDelayModel> base_delay_model_; |
There was a problem hiding this comment.
Is it necessary to change this from the abstract PlaceDelayModel to DeltaDelayModel? The idea was that any (potentially non-delta delay model) could be combined with this class to provide fix-up overrides.
There was a problem hiding this comment.
Serialization would require a mirroring of the inner model type. We could create a string registry of types, and then serialize the string. However, I didn't want to take that additional complexity right now given how few models we have.
Do we want to add such a registry now?
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
|
@litghost Thanks for addressing all the comments! |
Description
Bind
--read_placement_delay_lookupand--write_placement_delay_lookupto SerDes (implemented using Cap’n Proto).Motivation and Context
See justification in #707
This PR has predecessor PRs:
How Has This Been Tested?
Unit testing on SerDes, and some integration testing with Symbiflow.
Types of changes
Checklist: