Streaming Operator detection #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is called `verilog-at-streaming-op-p`. Also adds a check for streaming-op in `verilog-at-constraint-p`. (Streaming operators mistaken as constraints otherwise) This should fix veripool#1516
wsnyder
requested changes
Aug 22, 2020
verilog-mode.el
Outdated
| )) | ||
|
|
||
| (defun verilog-at-streaming-op-p () | ||
| "If at the { of a streaming operator, return true" |
There was a problem hiding this comment.
Suggested change
| "If at the { of a streaming operator, return true" | |
| "If at the { of a streaming operator, return t." |
(M-x checkdoc will otherwise complain if no period.)
However I wonder if this function is worth bothering with - perhaps just inline the code?
There was a problem hiding this comment.
If we do make it inline, we'll be putting code that checks if something is a streaming op or not, inside a function that itself checks if something is a constraint or not. Since constraints and streaming operators are not really related, this level of abstraction helps code readability by a significant amount, IMO.
Also, I believe this function is 'fundamental' enough, that we probably will end up using it at other places too.
The function is called `verilog-at-streaming-op-p`. Also adds a check for streaming-op in `verilog-at-constraint-p`. (Streaming operators mistaken as constraints otherwise) This should fix veripool#1516
vinamarora8
force-pushed
the
streaming-op-detect
branch
from
3e657c0
to
1414f5f
Compare
The particular test is taken from the issue veripool#1516. The issue has now been solved.
|
Thanks much for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 jobs:
verilog-streaming-op-re,verilog-at-streaming-op-pfor future use