Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get all items #187

Merged
merged 10 commits into from Jan 4, 2015
Merged

Get all items #187

merged 10 commits into from Jan 4, 2015

Conversation

vermiculus
Copy link
Owner

Implement a means to get all pages of a method call. Can be used in tag-bot.

@vermiculus
Add process-function to sx-request-make
5babd59
@vermiculus
Introduce `sx-request-all-items'
27eb38c 
This function repeatedly makes API requests until a condition is
satisfied (such as 'no more items').

First and foremost, this will allow us to retrieve all tags for a site.
@vermiculus
Consolidate state changes
f3bc9b6
@vermiculus
Introduce anti-throttling delay
caad878
@vermiculus
Copy link
Owner Author

Strictly speaking, the get-all function should recognize backoff and wait some multiple of the given delay (or some set amount). This would be a blocking call, though…

vermiculus referenced this pull request Jan 2, 2015
@Malabarba
Create the bot
5caf423
@vermiculus vermiculus mentioned this pull request Jan 2, 2015
Merged
@vermiculus
Copy link
Owner Author

Actually, backoff will tell you how long to wait before making another request. It might be worthwhile to factor this into sx-request -- recording the time of request that returned backoff and the delay that it said, then checking before making the request if the timing is ok.

@vermiculus vermiculus mentioned this pull request Jan 2, 2015
Open
@vermiculus
Remove process-function from request-all-items
07b9d0e 
It doesn't really make sense.
@vermiculus
Analog of request-all-items for sx-method-call
b67f83f
@vermiculus
Test new sx-method functionality
dea6019
@vermiculus
Fix test
63dcca1 
Dumb mistake -- I wasn't taking the length of the request before
comparing it.
@vermiculus vermiculus mentioned this pull request Jan 3, 2015
Merged
@Malabarba
Copy link
Collaborator

(Moved my comment to #188)

Malabarba
Malabarba reviewed Jan 3, 2015
View reviewed changes
sx-request.el
than `sx-request-response-get-items') to allow STOP-WHEN to
access the response wrapper."
;; @TODO: Refactor. This is the product of a late-night jam
;; session... it is not intended to be model code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the warning. :-)

@Malabarba
Copy link
Collaborator

Just made some small comments. Merge away when you'd like. 👍

@vermiculus
Copy link
Owner Author

I accidentally made the changes for your comments under #189 – since there were no functional changes, I'm going to merge. Thanks for looking this over!

vermiculus added a commit that referenced this pull request Jan 4, 2015
@vermiculus
Merge pull request #187 from vermiculus/get-all
3d35ecf 
Get all items
@vermiculus vermiculus merged commit 3d35ecf into master Jan 4, 2015
@vermiculus vermiculus deleted the get-all branch January 4, 2015 04:30
@Malabarba
Copy link
Collaborator

No problem!

@vermiculus vermiculus mentioned this pull request Jan 5, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vermiculus @Malabarba