Support FreeBSD and fixed macOS build failure #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks good to me, any remarks on MacOS @codeadict ? |
|
Thanks @michael-yuji, sorry I dropped off the radar after the initial PR :); got super busy with work. Seems like the remaining changes were Erlang code which I definitely wasn't going to be able to do in any short time frame.. |
|
@donileo and thanks to you too! :) |
|
I'll compile tonight on OSX @ioolkos and will give my seal of approval |
|
All looks great on OSX @ioolkos @michael-yuji. Great stuff! |
|
@codeadict thanks for testing! merging in a second. |
|
Hi i am getting these error on macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #9 by @donileo contains patches to
rebar.config.scriptsuch that it will be aware of the{"regex", "flag", "value"}styleport_envconfiguration. This PR will unbreak compilation failure on macOS while have the FreeBSD support added.