Added Vert.x Oracle Client #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsegismont
added a commit
to eclipse-vertx/vertx-sql-client
that referenced
this pull request
Oct 20, 2022
This is prep work for vert-x3/vertx-lang-kotlin#215 We didn't have any issue before because Oracle Client has no RxJava / Kotlin binding yet Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
add_oracle_client
branch
from
adc3ce8
to
84933a1
Compare
Fix build issues related to Oracle Client * on GH actions, use Java 11 for testing / deployment * In the parent POM, change the compiler config when JDK11+ is detected so that Java 8 APIs are enforced in vertx-lang-kotlin sources * In vertx-lang-kotlin POM, configure toolchain plugin for people running Maven with Java8 Javadoc plugin fails with JDK11 It is stricter than JDK8 and fails because source param should contain a JDK version. Updated generated files Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
add_oracle_client
branch
from
84933a1
to
6e46507
Compare
|
@vietj fixed that one too, PTAL |
vietj
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.