Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate projects without Gradle #69

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

tsegismont
Copy link
Collaborator

This PR removes the need for the backend generator (based on Gradle).

Instead, it uses the Vert.x template engine, Vert.x filesystem and Apache Commons Compress (no TAR support in the JDK).

@tsegismont
Copy link
Collaborator Author

Also, it fixes #66

@danielpetisme
Copy link
Contributor

Thanks for this huge refactoring effot 👏 .

Finally we go back to the the templating option 🤔 obviously it looks easier to integrate but a bit harder to debug. Do you think we can provide some tests to check the project generations (with the Gradle backend I used to generate the matrix combination, trigger each generation and run the default build, test actions).

@tsegismont
Copy link
Collaborator Author

Thanks for this huge refactoring effort

You're welcome :)

Finally we go back to the the templating option thinking obviously it looks easier to integrate but a bit harder to debug.

The current Gradle backend also relies on templating. In this regard, it is not much different.

Do you think we can provide some tests to check the project generations (with the Gradle backend I used to generate the matrix combination, trigger each generation and run the default build, test actions).

Do you mean, build the generated project before sending it back to the client?

@jponge
Copy link
Member

jponge commented Jan 22, 2019

@tsegismont we already have #31 😉

@tsegismont
Copy link
Collaborator Author

tsegismont commented Jan 22, 2019 via email

@tsegismont tsegismont requested a review from jponge March 5, 2019 22:46
Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsegismont tsegismont merged commit 4465328 into vert-x3:master Mar 6, 2019
@tsegismont
Copy link
Collaborator Author

Thanks @jponge

@tsegismont tsegismont deleted the without-gradle branch March 6, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants