-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate projects without Gradle #69
Conversation
Also, it fixes #66 |
d835773
to
796416e
Compare
Thanks for this huge refactoring effot 👏 . Finally we go back to the the templating option 🤔 obviously it looks easier to integrate but a bit harder to debug. Do you think we can provide some tests to check the project generations (with the Gradle backend I used to generate the matrix combination, trigger each generation and run the default build, test actions). |
You're welcome :)
The current Gradle backend also relies on templating. In this regard, it is not much different.
Do you mean, build the generated project before sending it back to the client? |
@tsegismont we already have #31 😉 |
Perfect.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jponge |
This PR removes the need for the backend generator (based on Gradle).
Instead, it uses the Vert.x template engine, Vert.x filesystem and Apache Commons Compress (no TAR support in the JDK).