Vert.x Web routes with '+' in fragment are not resolved

[Jotschi]

Version

• vert.x web: 3.3.2 and 3.4.0-SNAPSHOT @ 0bd69d5

Context

Routes which include a plus sign character ('+') are not resolved.
RFC3986 states that a URI fragment may contain pchar which in turn is defined as:

  pchar         = unreserved / pct-encoded / sub-delims / ":" / "@"

And subdelims contains '+'

  sub-delims    = "!" / "$" / "&" / "'" / "(" / ")"
                 / "*" / "+" / "," / ";" / "="

Do you have a reproducer?

Test case for RouterTest class:

  @Test
  public void testGetWithPlusPath() throws Exception {
    router.get("/some+path/").handler(rc -> {
      rc.response().setStatusMessage("foo").end();
    });
    testRequest(HttpMethod.GET, "/some+path/", 200, "foo");
  }

Steps to reproduce

1. Add route which includes the '+' character in the route segment
2. Invoke request to URL

[Jotschi]

I noticed that vert.x web is normalizing the path via:
https://github.com/vert-x3/vertx-web/blob/master/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java#L62

[luengnat]

@Jotschi even when "normalisePath" is turned off, the pattern matching is still wrong since if you have a pattern router.get("/:param1"), it match /albert+einstein as { param1: "albert einstein" } while in fact "+" should not be unescaped.

[pmlopes]

This issue has been superseded by #443