-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mysql] add custom jdbc properties to debezium mysql connection (#674) #1217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ruanhang1993 for the contribution, I left some comments
flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/MySqlValidator.java
Show resolved
Hide resolved
...ql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReader.java
Outdated
Show resolved
Hide resolved
.../com/ververica/cdc/connectors/mysql/source/connection/MySqlConnectionWithJdbcProperties.java
Outdated
Show resolved
Hide resolved
.../com/ververica/cdc/connectors/mysql/source/connection/MySqlConnectionWithJdbcProperties.java
Outdated
Show resolved
Hide resolved
.../com/ververica/cdc/connectors/mysql/source/connection/MySqlConnectionWithJdbcProperties.java
Outdated
Show resolved
Hide resolved
.../com/ververica/cdc/connectors/mysql/source/connection/MySqlConnectionWithJdbcProperties.java
Outdated
Show resolved
Hide resolved
3640a5b
to
621d96f
Compare
DebeziumUtils.createMySqlConnection( | ||
from(dbzProperties), sourceConfig.getJdbcProperties()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DebeziumUtils.createMySqlConnection( | |
from(dbzProperties), sourceConfig.getJdbcProperties()); | |
DebeziumUtils.createMySqlConnection(sourceConfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used by the legacy source whose sourceConfig
is null. I will revert this change to use new Properties()
.
Hi there! Trying to update com.ververica:flink-connector-mysql-cdc from 2.2.1 to 2.3.0 version and getting such Exception:
As I understand, the reason because I have two dependencies as result: with the same class io.debezium.connector.mysql.MySqlConnection$MySqlConnectionConfiguration but first one with only one constructor. So the question is, why was this class renamed in this commit 5415bcf and how may I fix this issue? |
With 2.4.0 the same issue |
This PR fix the bug that the mysql jdbc connection does not contain the jdbc properties set by users.
The problem is that the debezium mysql connection uses the fixed url pattern.
Changes: