Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup circle and coveralls #21

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Setup circle and coveralls #21

merged 2 commits into from
Feb 18, 2019

Conversation

danielspofford
Copy link
Contributor

@danielspofford danielspofford commented Feb 17, 2019

Why

How

  • Add circle config
  • Add circle badge to readme
  • Add excoveralls
  • run coveralls in ci
  • Add coveralls badge to readme
  • Enforce current coverage of 60%

Why
---

- To automate checks

How
---

- Add circle config
- Add circle badge to readme
Copy link
Contributor

@squaresurf squaresurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing this forward. I have a couple questions.

.circleci/config.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Why
---

- To track test coverage

How
---

- Update circle config
  - fetch rebar
  - run coveralls instead of test
- Add coveralls badge to readme
- Add excoveralls
- Enforce current coverage of 60%
@danielspofford danielspofford merged commit 6d1fd97 into master Feb 18, 2019
@danielspofford danielspofford deleted the circle branch February 18, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants