-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: httpclient support set tls config #30
Conversation
9847693
to
ea36602
Compare
httpclient/client.go
Outdated
@@ -90,6 +108,12 @@ func WithAuthToken(token string) RequestOption { | |||
} | |||
} | |||
|
|||
func WithNewClientHookHook(fn func(*resty.Client)) RequestOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HookHook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
httpclient/client_test.go
Outdated
@@ -54,6 +55,67 @@ func TestNewClient(t *testing.T) { | |||
} | |||
} | |||
|
|||
func TestWithNewClientHookHook(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: