This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Expose time utils. #571
Merged
Expose time utils. #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2021
Aiee
reviewed
Jun 25, 2021
laura-ding
reviewed
Jun 28, 2021
laura-ding
reviewed
Jun 28, 2021
src/common/time/TimeUtils.cpp
Outdated
| return dateTimeShift(dateTime, Timezone::getGlobalTimezone().utcOffsetSecs()); | ||
| } | ||
|
|
||
| /*static*/ StatusOr<DateTime> TimeUtils::localDateTime() { |
There was a problem hiding this comment.
LocalDateTime () does not need to be exposed to the user, so StatusOr and Status does not need to be exposed to the cpp client
There was a problem hiding this comment.
Many method return status.
laura-ding
reviewed
Jun 30, 2021
src/common/base/StatusOr.h
Outdated
| @@ -230,12 +233,12 @@ class StatusOr final { | |||
| // Return the associated `Status' if and only if it has one, | |||
| // | |||
| Status status() const & { | |||
| CHECK(hasStatus()); | |||
| assert(hasStatus()); | |||
There was a problem hiding this comment.
The Status no need to expose to the client, you can revert it.
Shylock-Hg
force-pushed
the
feature/expose-time-utils
branch
from
100635a
to
c3cbb89
Compare
laura-ding
previously approved these changes
Jun 30, 2021
laura-ding
approved these changes
Jun 30, 2021
Aiee
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the time utils which used in cpp-client.