Add timezone conversion. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-ding
reviewed
Jun 28, 2021
| @@ -48,4 +50,17 @@ void Session::release() { | |||
| } | |||
| } | |||
|
|
|||
| void Session::toLocal(DataSet &data, int32_t offsetSecs) { | |||
There was a problem hiding this comment.
You don't have to provide a method like that, but you can tell user how to get localTime and get localDateTime in example code
There was a problem hiding this comment.
I will add example.
There was a problem hiding this comment.
The interface better move to test code, no need to provide it to the user
There was a problem hiding this comment.
User could use or not.
…ebula-cpp into feature/timezone-conversion
…ebula-cpp into feature/timezone-conversion
laura-ding
previously approved these changes
Jun 30, 2021
|
Please fix the ci test |
laura-ding
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require vesoft-inc/nebula-common#571