Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datasource add clickhouse and maxcompute #794

Merged
merged 12 commits into from
Aug 11, 2021
Merged

datasource add clickhouse and maxcompute #794

merged 12 commits into from
Aug 11, 2021

Conversation

cooper-lzy
Copy link
Contributor

No description provided.

@Nicole00
Copy link
Contributor

Nicole00 commented Aug 3, 2021

建议在 导入命令文档中加上 如果使用yarn-cluster模式进行任务提交的说明，参考readme https://github.com/vesoft-inc/nebula-spark-utils/tree/master/nebula-exchange

whitewum
whitewum reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是支持2.0.1内核的，直接向v2.0.1branch发pull request
内核的2.5.0和2.0.1会有很多不同和不兼容
这个部分pr cherrypick过来，文件注释掉

docs-2.0/nebula-exchange/about-exchange/ex-ug-what-is-exchange.md Outdated Show resolved Hide resolved
docs-2.0/nebula-exchange/ex-ug-compile.md Outdated Show resolved Hide resolved
docs-2.0/nebula-exchange/ex-ug-compile.md Outdated Show resolved Hide resolved
docs-2.0/nebula-exchange/ex-ug-compile.md Outdated Show resolved Hide resolved
whitewum
whitewum suggested changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一一下jar的版本号
必须和内核对齐。
master是2.5.0，不要向master提交2.0.1内核的内容。

@cooper-lzy cooper-lzy added the wip Solution: work in progress label Aug 3, 2021
@cooper-lzy cooper-lzy changed the title datasource add clickhouse and maxcompute [WIP]datasource add clickhouse and maxcompute Aug 3, 2021
@cooper-lzy cooper-lzy changed the title [WIP]datasource add clickhouse and maxcompute datasource add clickhouse and maxcompute Aug 10, 2021
@cooper-lzy cooper-lzy removed the wip Solution: work in progress label Aug 10, 2021
@Nicole00
Copy link
Contributor

建议文档中的192.168.*.*这类表示ip的 可以统一使用127.0.0.1

foesa-yang
foesa-yang previously approved these changes Aug 11, 2021
View reviewed changes
@cooper-lzy cooper-lzy dismissed stale reviews from foesa-yang and whitewum via 0136337 August 11, 2021 02:46
@randomJoe211 randomJoe211 merged commit 121cf3d into vesoft-inc:master Aug 11, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Aug 14, 2021
Closed
@cooper-lzy cooper-lzy deleted the support-ClickHouse-datasource branch November 25, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicole00 Nicole00 Nicole00 left review comments

@foesa-yang foesa-yang foesa-yang approved these changes

@randomJoe211 randomJoe211 randomJoe211 approved these changes

@whitewum whitewum whitewum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cooper-lzy @Nicole00 @foesa-yang @whitewum @randomJoe211