Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.18 #322

Closed
wants to merge 1 commit into from
Closed

Upgrade to Go 1.18 #322

wants to merge 1 commit into from

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Feb 24, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

closes #314

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.73%. Comparing base (9bfafce) to head (5179638).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files          11       11           
  Lines        2705     2705           
=======================================
  Hits         1751     1751           
  Misses        810      810           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QingZ11 QingZ11 requested a review from Nicole00 March 5, 2024 04:00
@haoxins
Copy link
Collaborator Author

haoxins commented Apr 10, 2024

duplicated with #337

@haoxins haoxins closed this Apr 10, 2024
@haoxins haoxins deleted the go118 branch April 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we only support Go 1.18+
2 participants