Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement:support more type value as parameter in session.value2Nvalue #511

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

CorvusYe
Copy link
Contributor

@CorvusYe CorvusYe commented Feb 24, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

The original push request is #461

What problem(s) does this PR solve?

Description:

When executeWithParameter is called in session,
we expect more type to be valid params not only boolean/float/int/string/map/list.

How do you solve it?

On the basis of the original support types, the support for pojo, collection and time has been expanded.
The pojo type uses reflection values to convert to Map

graph TB
S--value-->N
N--Y_NullType-->E
N--N-->L
L--Y-->XV
XV-->E

L--N-->CV
CV-->S

CV(Collect_for / Map_for / Date: unit item)
XV(Value.xxxVal)
L{is leaf type}
S(value2Nvalue)
N{value is null}
E(return nValue)
Loading

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@wey-gu wey-gu changed the title enhancement:support more type value as parameter in session.value2Nvalue enhancement:support more type value as parameter in session.value2Nvalue Feb 24, 2023
@wey-gu wey-gu requested a review from Nicole00 February 24, 2023 05:14
Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicole00 Nicole00 merged commit 0feaf3e into vesoft-inc:master Feb 24, 2023
Nicole00 added a commit that referenced this pull request Mar 30, 2023
* check connection by default #401 (#456)

* enhancement:support more type value as parameter in session.value2Nvalue (#511)

* enhancement:support more type value as parameter in session.value2Nvalue

* code style for #511

* code style for #511

* Add maven wrapper (#513)

Co-authored-by: Will Droste <will.droste@brinqa.com>

* recreate session for both session error and connection exception

* fix style check

* sleep for docker restart

---------

Co-authored-by: vchangpengfei <37330503+vchangpengfei@users.noreply.github.com>
Co-authored-by: 大叶 <CorvusY@foxmail.com>
Co-authored-by: Will Droste <will.droste@brinqa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants