Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use maven wrapper to release the dependency on maven #513

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Feb 24, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #512

Description:

How do you solve it?

Thanks @wdroste for your contribution about mvnw, refer #486

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 63.75% // Head: 64.01% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (8ad4de0) compared to base (0feaf3e).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
+ Coverage     63.75%   64.01%   +0.26%     
- Complexity      789      793       +4     
============================================
  Files            72       72              
  Lines          3824     3824              
  Branches        527      527              
============================================
+ Hits           2438     2448      +10     
+ Misses         1019     1011       -8     
+ Partials        367      365       -2     
Impacted Files Coverage Δ
...va/com/vesoft/nebula/client/graph/SessionPool.java 57.62% <0.00%> (ø)
...java/com/vesoft/nebula/client/meta/MetaClient.java 57.34% <0.00%> (+4.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wey-gu
Copy link
Contributor

wey-gu commented Feb 24, 2023

Thanks @wdroste !

@wdroste
Copy link
Contributor

wdroste commented Feb 24, 2023

👍

@Nicole00 Nicole00 merged commit 7027f6c into vesoft-inc:master Feb 27, 2023
@Nicole00 Nicole00 deleted the maven branch February 27, 2023 09:11
Nicole00 added a commit that referenced this pull request Mar 30, 2023
* check connection by default #401 (#456)

* enhancement:support more type value as parameter in session.value2Nvalue (#511)

* enhancement:support more type value as parameter in session.value2Nvalue

* code style for #511

* code style for #511

* Add maven wrapper (#513)

Co-authored-by: Will Droste <will.droste@brinqa.com>

* recreate session for both session error and connection exception

* fix style check

* sleep for docker restart

---------

Co-authored-by: vchangpengfei <37330503+vchangpengfei@users.noreply.github.com>
Co-authored-by: 大叶 <CorvusY@foxmail.com>
Co-authored-by: Will Droste <will.droste@brinqa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use maven wrapper to release the dependency on maven
4 participants