feat: add spec port #281
Merged
feat: add spec port #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wenhaocs The ports exposed in spec looks good, if the default value updated then add a flag to cmd line to overwrite local conf file. |
MegaByte875
approved these changes
Sep 19, 2023
Comment on lines
+367
to
+372
| // +kubebuilder:default=9669 | ||
| Port int32 `json:"port,omitempty"` | ||
|
|
||
| // +optional | ||
| // +kubebuilder:default=19669 | ||
| HTTPPort int32 `json:"httpPort,omitempty"` |
There was a problem hiding this comment.
set validation:Maximum and validation:Minimum
veezhang
reviewed
Sep 19, 2023
Comment on lines
+210
to
+213
| IsDefaultThriftPort() bool | ||
| GetThriftPort() int32 | ||
| IsDefaultHTTPPort() bool | ||
| GetHTTPPort() int32 |
There was a problem hiding this comment.
Why not just use GetXxxPort? The default value is already defined in CRD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: