This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
Increase meta client connection timeout。 #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codelone
changed the title
Nicole00
reviewed
Oct 11, 2021
| @@ -30,7 +30,7 @@ class MetaProvider(addresses: List[HostAndPort], timeout: Int, retry: Int) | |||
| address.append(new HostAddress(addr.getHostText, addr.getPort)) | |||
| } | |||
|
|
|||
| private val metaClient = new MetaClient(address.asJava) | |||
| private val metaClient = new MetaClient(address.asJava,6000,3,3) | |||
There was a problem hiding this comment.
please use the timeout and retry parameter.
Nicole00
reviewed
Oct 11, 2021
| @@ -18,7 +18,7 @@ import scala.collection.mutable | |||
| class MetaProvider(addresses: List[Address]) extends AutoCloseable { | |||
|
|
|||
| val metaAddress = addresses.map(address => new HostAddress(address._1, address._2)).asJava | |||
| val client = new MetaClient(metaAddress) | |||
| val client = new MetaClient(metaAddress,6000,3,3) | |||
There was a problem hiding this comment.
the timeout and retry number should be parameter
Nicole00
reviewed
Oct 11, 2021
| val metaAddress = addresses.map(address => new HostAddress(address._1, address._2)).asJava | ||
| val client = new MetaClient(metaAddress) | ||
| val client = new MetaClient(metaAddress,DEFAULT_TIMEOUT_MS,DEFAULT_CONNECTION_RETRY_SIZE,DEFAULT_EXECUTION_RETRY_SIZE) |
There was a problem hiding this comment.
we should get timeout and retry parameter from NebulaConnectionConfig
|
Thanks for your contribution for Nebula-Exchange and Nebula-Spark-Connector， now this repo has been split into three different repos, could you please submit two pr to repo https://github.com/vesoft-inc/nebula-exchang and repo https://github.com/vesoft-inc/nebula-spark-connector. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta client connection ， 1 second will often timeout， Increase to 6 seconds。