This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
fix task in recovered balance plan is still marked as FAILED #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
liuyu85cn,
panda-sheep,
bright-starry-sky,
cangfengzhs,
darionyaphet and
linkensphere201
|
There will be more changes, hold on one second. |
| @@ -36,6 +36,10 @@ folly::Future<Status> AdminClient::transLeader(GraphSpaceID spaceId, | |||
| if (it == peers.end()) { | |||
| return Status::PartNotFound(); | |||
| } | |||
| if (peers.size() == 1 && peers.front() == leader) { | |||
There was a problem hiding this comment.
make sure the leader is being selected?
There was a problem hiding this comment.
No, transfer leader will failed in some case when replica is 1. see #458.
panda-sheep
approved these changes
Jul 19, 2021
critical27
added a commit
that referenced
this pull request
Aug 2, 2021
* fix task in recovered balance plan is still marked as FAILED (#528) * fix task in recovered balance plan is still marked as FAILED * fix bugs * Fix db_dump print int vid (#533) * fix db_dump print int vid * fix --vids * fix partId * use new common Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When task is failed for some reason, when recovering, they are marked as
IN_PROGRESSagain, butbalance data idwill still showFAILED. Just save the status when plan is recovered.