Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Fix db_dump print int vid #533

Merged
merged 4 commits into from
Jul 23, 2021
Merged

Fix db_dump print int vid #533

merged 4 commits into from
Jul 23, 2021

Conversation

laura-ding
Copy link
Contributor

@laura-ding laura-ding commented Jul 22, 2021

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Jul 22, 2021
critical27
critical27 previously approved these changes Jul 22, 2021
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

panda-sheep
panda-sheep previously approved these changes Jul 22, 2021
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@laura-ding laura-ding dismissed stale reviews from panda-sheep and critical27 via 478b737 July 22, 2021 13:50
critical27
critical27 previously approved these changes Jul 23, 2021
@critical27 critical27 merged commit 249bc46 into vesoft-inc:master Jul 23, 2021
critical27 added a commit that referenced this pull request Aug 2, 2021
* fix task in recovered balance plan is still marked as FAILED (#528)

* fix task in recovered balance plan is still marked as FAILED

* fix bugs

* Fix db_dump print int vid (#533)

* fix db_dump print int vid

* fix --vids

* fix partId

* use new common

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vid not ASCII/printable in dump tools when it's int-typed
3 participants