-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update index page #131
Conversation
<div | ||
{...provided.droppableProps} | ||
ref={provided.innerRef} | ||
style={getListStyle()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use constant instead of function ?
name, | ||
}); | ||
if (res.code === 0) { | ||
await getRebuildData(type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary await
@@ -37,7 +37,7 @@ const Schema = () => { | |||
if (!err) { | |||
history.push(`/schema/${space}/tag/list`); | |||
} else if (err && err.toLowerCase().includes('spacenotfound')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err
is certain truthy
mod: code review
No description provided.