Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issues #311

Merged
merged 3 commits into from
Oct 13, 2022
Merged

fix: fix issues #311

merged 3 commits into from
Oct 13, 2022

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Oct 13, 2022

No description provided.

mod: code review
Comment on lines 141 to 156
if(srcId && !nodes.find(i => i.vid === srcId)) {
nodes.push({
...NODE_CONFIG,
...DANLEING_NODE_CONFIG,
vid: srcId,
uuid: uuidv4(),
});
}
if(dstId && !nodes.find(i => i.vid === dstId)) {
nodes.push({
...NODE_CONFIG,
...DANLEING_NODE_CONFIG,
vid: dstId,
uuid: uuidv4(),
});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[srcId, dstId].forEach((vid) => vid && nodes.every((i) => i.vid !== vid) && nodes.push({
  ...NODE_CONFIG,
  ...DANLEING_NODE_CONFIG,
  vid,
  uuid: uuidv4(),
}));

mod: code review
Copy link
Contributor

@huaxiabuluo huaxiabuluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxiabuluo huaxiabuluo merged commit 84a0282 into vesoft-inc:master Oct 13, 2022
@hetao92 hetao92 deleted the hetao-fix branch October 14, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants