Adjusted default # of threads of graphd to # of CPU cores #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
monadbobo,
yixinglu,
darionyaphet,
CPWstatic,
laura-ding and
whitewum
|
Unit testing failed. |
whitewum
approved these changes
Oct 16, 2019
Comment on lines
+113
to
119
| if (FLAGS_num_netio_threads == 0) { | ||
| FLAGS_num_netio_threads = std::thread::hardware_concurrency(); | ||
| } | ||
| if (FLAGS_num_netio_threads <= 0) { | ||
| LOG(WARNING) << "Number of networking IO threads should be greater than zero"; | ||
| return EXIT_FAILURE; | ||
| } |
There was a problem hiding this comment.
combine these two conditions ?
My thought: FLAGS_num_netio_threads <= 0 means all cores
There was a problem hiding this comment.
0 is to be a legal option and the only option to indicate number of cores, while a negative value is not. The second check is to cover the negative AND the failure case(hard_concurrency has chances to fail)
Comment on lines
+122
to
+128
| if (FLAGS_num_worker_threads == 0) { | ||
| FLAGS_num_worker_threads = std::thread::hardware_concurrency(); | ||
| } | ||
| if (FLAGS_num_worker_threads <= 0) { | ||
| LOG(WARNING) << "Number of worker threads should be greater than zero"; | ||
| return EXIT_FAILURE; | ||
| } |
yixinglu
reviewed
Oct 16, 2019
| @@ -36,10 +36,10 @@ | |||
| --session_idle_timeout_secs=60000 | |||
| # The number of threads to accept incoming connections | |||
| --num_accept_threads=1 | |||
There was a problem hiding this comment.
Miss this option?
Nope. Mostly, one single thread is enough to handle incomming connections.
| @@ -16,7 +16,7 @@ DEFINE_int32(session_reclaim_interval_secs, 10, "Period we try to reclaim expire | |||
| DEFINE_int32(num_netio_threads, 0, | |||
| "Number of networking threads, 0 for number of physical CPU cores"); | |||
| DEFINE_int32(num_accept_threads, 1, "Number of threads to accept incoming connections"); | |||
|
Unit testing passed. |
whitewum
approved these changes
Oct 17, 2019
yixinglu
approved these changes
Oct 21, 2019
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.