Correct issue 2009 which the timestamp default value for edge not treat. #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shylock-Hg
requested review from
darionyaphet,
CPWstatic,
critical27,
dangleptr,
dutor,
jude-zhu,
laura-ding and
monadbobo
|
TODO: Add cases to nebula/test |
laura-ding
reviewed
Apr 1, 2020
There was a problem hiding this comment.
Well done! The pr #1452 missed modify it.
I think this should be encapsulated as a function , create tag/edge/ alter schema are use it, there is too much redundant code and maintenance is easy to miss.
| if (value->getType() != nebula::cpp2::Value::Type::timestamp) { | ||
| LOG(ERROR) << "Create Edge Failed: " << name | ||
| << " type mismatch"; | ||
| handleErrorCode(cpp2::ErrorCode::E_CONFLICT); |
There was a problem hiding this comment.
Here should be E_INVALID_PARM
There was a problem hiding this comment.
I want to keep same with before.
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
- Coverage 86.90% 86.73% -0.18%
==========================================
Files 636 641 +5
Lines 59819 61076 +1257
==========================================
+ Hits 51984 52972 +988
- Misses 7835 8104 +269
Continue to review full report at Codecov.
|
laura-ding
previously approved these changes
Apr 1, 2020
CPWstatic
approved these changes
Apr 2, 2020
jude-zhu
pushed a commit
to jude-zhu/nebula
that referenced
this pull request
Apr 2, 2020
…at. (vesoft-inc#2038) * Correct issue 2009 which the timestamp default value for edge not treat. * Add the cover cases. * Fix one typo. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 4aa9217)
dutor
pushed a commit
that referenced
this pull request
Apr 2, 2020
* remove bigint because we dont support it (#2031) Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 3423df1) * fix crash (#2042) Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit eea7407) * Sampling apply to all edges starting from a vertex. (#2013) * Sampling from all edges. * Update test for sampling multi edges. * Testing both inbound and outbound. * Fix clang compiling problem. * Update the sampling. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 8810ecc) * Fix the error when vertex/edge not exist if update. (#2025) * Fix the error when vertex/edge not exist if update. * Optimize the atomic error logical. * Fix one alignment. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 9fc4e7f) * Correct issue 2009 which the timestamp default value for edge not treat. (#2038) * Correct issue 2009 which the timestamp default value for edge not treat. * Add the cover cases. * Fix one typo. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 4aa9217) Co-authored-by: flyingcat <1004815462@qq.com> Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com> Co-authored-by: CPWstatic <13495049+CPWstatic@users.noreply.github.com> Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…at. (vesoft-inc#2038) * Correct issue 2009 which the timestamp default value for edge not treat. * Add the cover cases. * Fix one typo. Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
vesoft-inc#2038) * Enhance MemoryStats to avoid the false sharing effect on the CPU cache * small rename Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?