Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double support scientific notation. #2079

Merged
merged 2 commits into from
Apr 17, 2020
Merged

double support scientific notation. #2079

merged 2 commits into from
Apr 17, 2020

Conversation

xuguruogu
Copy link
Collaborator

Parser can deal with scientific notation like 123.456E1.

Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@CPWstatic CPWstatic added doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test labels Apr 16, 2020
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It is better to add a test to get the value.

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.
IMO. Integers are also deserved to support such notation.

@xuguruogu
Copy link
Collaborator Author

1E10 is supposed to be regard as integer or double? The format is rarely used.

@codecov-io
Copy link

Codecov Report

Merging #2079 into master will decrease coverage by 0.09%.
The diff coverage is 92.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2079      +/-   ##
==========================================
- Coverage   86.90%   86.80%   -0.10%     
==========================================
  Files         636      639       +3     
  Lines       59819    61130    +1311     
==========================================
+ Hits        51984    53066    +1082     
- Misses       7835     8064     +229     
Impacted Files Coverage Δ
src/common/base/Configuration.h 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.cpp 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.h 90.41% <ø> (ø)
src/common/utils/test/NebulaKeyUtilsTest.cpp 97.10% <ø> (ø)
src/graph/DescribeSpaceExecutor.h 0.00% <ø> (ø)
src/graph/Executor.cpp 74.76% <ø> (-0.91%) ⬇️
src/graph/Executor.h 94.73% <ø> (-5.27%) ⬇️
src/graph/FetchEdgesExecutor.h 0.00% <ø> (ø)
src/graph/FetchExecutor.cpp 88.88% <ø> (+0.59%) ⬆️
src/graph/FetchVerticesExecutor.h 0.00% <ø> (ø)
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1b79e...7809afa. Read the comment docs.

@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Apr 17, 2020

1E10 is supposed to be regard as integer or double? The format is rarely used.

I think it's a double, such as the .3 or 3. are treat as double also in c/c++ grammar. So I think it's intuitive grammar for user. And we have already the notation for integer.

@dutor dutor merged commit 2d6cf8e into vesoft-inc:master Apr 17, 2020
@amber-moe
Copy link
Contributor

doc done

tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Co-authored-by: trippli <trippli@tencent.com>
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* drop space not exist

* return when key not found

Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants