Support GO M TO N STEPS which record the data in go traversal.
#2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amber1990Zhang
added
the
doc affected
Codecov Report
@@ Coverage Diff @@
## master #2091 +/- ##
==========================================
+ Coverage 86.70% 86.81% +0.10%
==========================================
Files 641 641
Lines 61190 61523 +333
==========================================
+ Hits 53056 53411 +355
+ Misses 8134 8112 -22
Continue to review full report at Codecov.
|
CPWstatic
reviewed
May 6, 2020
monadbobo
reviewed
May 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #2091 +/- ##
==========================================
+ Coverage 86.84% 86.88% +0.04%
==========================================
Files 641 641
Lines 61651 61983 +332
==========================================
+ Hits 53541 53856 +315
- Misses 8110 8127 +17
Continue to review full report at Codecov.
|
CPWstatic
approved these changes
May 21, 2020
laura-ding
reviewed
May 21, 2020
| return; | ||
| } | ||
| starts_ = std::move(status).value(); | ||
| auto dsts = getDstIdsFromResps(records_.end() - 1, records_.end()); |
There was a problem hiding this comment.
modify records_.end() - 1 to records_.rbegin()
There was a problem hiding this comment.
I don't think it's better clear.
| return; | ||
| } | ||
|
|
||
| void GoExecutor::onVertexProps(RpcResponse &&rpcResp) { | ||
| UNUSED(rpcResp); | ||
| } | ||
|
|
||
| StatusOr<std::vector<VertexID>> GoExecutor::getDstIdsFromResp(RpcResponse &rpcResp) const { | ||
| std::vector<VertexID> GoExecutor::getDstIdsFromResps(std::vector<RpcResponse>::iterator begin, |
There was a problem hiding this comment.
How about std::vector<VertexID> GoExecutor::getDstIdsFromResps(uint32_t beginPos) the beginPos is the first element of recordFrom.
There was a problem hiding this comment.
I think iterator is better.
It's to unify the process. Won't record the unused properties. |
dutor
added
ready-for-testing
jude-zhu
pushed a commit
to jude-zhu/nebula
that referenced
this pull request
May 22, 2020
…oft-inc#2091) * Support `GO M TO N STEPS` which record the data in go traversal. * Add the parser testing. * Put the variable to cross all loop. * Add test. * Comfirm the bidirectionally cases. * Add cases for over *. * Let the intermidiate response return the properies if specified.
dutor
pushed a commit
that referenced
this pull request
May 22, 2020
…) (#2136) * Support `GO M TO N STEPS` which record the data in go traversal. * Add the parser testing. * Put the variable to cross all loop. * Add test. * Comfirm the bidirectionally cases. * Add cases for over *. * Let the intermidiate response return the properies if specified. Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
|
doc done |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…oft-inc#2091) * Support `GO M TO N STEPS` which record the data in go traversal. * Add the parser testing. * Put the variable to cross all loop. * Add test. * Comfirm the bidirectionally cases. * Add cases for over *. * Let the intermidiate response return the properies if specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support the grammar
GO [[<M> TO] <N> STEPS]to collect the data in GO traversal.If can't reach N steps, return empty now.(Will be change in #2148
Why are the changes needed?
Does this PR introduce any user-facing change?
Yes, @Amber1990Zhang
How was this patch tested?
Checklist