Let the m to n steps return the data even if can't reach n steps. #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om:Shylock-Hg/nebula into correct/return-m-to-n-data-when-cant-reach
This reverts commit fbe28b7.
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 86.84% 86.83% -0.01%
==========================================
Files 641 641
Lines 61651 62022 +371
==========================================
+ Hits 53541 53859 +318
- Misses 8110 8163 +53
Continue to review full report at Codecov.
|
3 tasks
CPWstatic
approved these changes
May 28, 2020
laura-ding
reviewed
May 28, 2020
| @@ -695,8 +703,8 @@ void GoExecutor::finishExecution() { | |||
| StatusOr<std::vector<cpp2::RowValue>> GoExecutor::toThriftResponse() const { | |||
| std::vector<cpp2::RowValue> rows; | |||
| int64_t totalRows = 0; | |||
| for (const auto &rpcResp : records_) { | |||
| for (const auto& resp : rpcResp.responses()) { | |||
| for (auto rpcResp = records_.begin() + recordFrom_ - 1; rpcResp != records_.end(); ++rpcResp) { | |||
laura-ding
approved these changes
May 28, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…soft-inc#2148) * Let the m to n steps return the data even if can't reach n steps. * Unify the go exit entry. * Revert "Unify the go exit entry." This reverts commit fbe28b7. * Unify the go exit entry. * Fix the edges reserve count. * Add a cases for record a part data in go. * Fix DAIL-91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Keep return data even if can't reach N steps.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Checklist